Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format package names in GitHub issues #1141

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

I spotted shreekarSS/aicoe-osc-demo#2 and thought that a bit of formatting could help understand the message.

This introduces a breaking change

No

This Pull Request implements

Minor improvement of the formatting / wording on package manager when creating issues.

Before: plain text.

After: package name and Pipfile entry are formatted.

Signed-off-by: Pep Turró Mauri <pep@redhat.com>
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
👍

@harshad16
Copy link
Member

PTAL @KPostOffice
Thanks

@codificat
Copy link
Member Author

PTAL @KPostOffice

rewording:
/assign @KPostOffice

😇 thanks!

@sesheta
Copy link
Member

sesheta commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KPostOffice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 17, 2022
@sesheta sesheta merged commit 285c57c into thoth-station:master Oct 17, 2022
@codificat codificat deleted the format-pkg-name branch October 17, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants