Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add check for no PRs opened #1155

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

fixes: #1145

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

add check to see if any PRs were opened by the update manager.

@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 10, 2022
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a minor suggestion about the message: I believe it would be more clear to highlight that things are already up to date instead of focusing on the lack of an update.

else:
self.close_issue_and_comment(
_ISSUE_MANUAL_UPDATE,
comment="No update was performed, dependencies up to date.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about:

Suggested change
comment="No update was performed, dependencies up to date.",
comment="The dependencies are already up to date. No update is needed at this time.",

@codificat
Copy link
Member

/approve

@sesheta
Copy link
Member

sesheta commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@sesheta sesheta merged commit af3383e into thoth-station:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1pt] kebechet fail close the dependency update issue if there is no changes needed
3 participants