Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default in case there are no runtime environments #1172

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

KPostOffice
Copy link
Member

some managers do not require python runtime environments, like the version manager. I changed to use an empty list as a default in this case. Any loops over runtime environments just won't run

Signed-off-by: Kevin kpostlet@redhat.com

Related Issues and Dependencies

fixes: #1169

some managers do not require python runtime environments, like
the version manager. I changed to use an empty list as a default
in this case. Any loops over runtime environments just won't run

Signed-off-by: Kevin <kpostlet@redhat.com>
@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

thanks 👍

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2022
@sesheta
Copy link
Member

sesheta commented Nov 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2022
@harshad16
Copy link
Member

/test pre-commit

@sesheta sesheta merged commit 8c0d014 into thoth-station:master Nov 16, 2022
@KPostOffice KPostOffice deleted the managers-wo-envs branch November 29, 2022 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facing issue when using kebechet for version update only
3 participants