Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get relative path of overlay currently being updated for link #816

Merged
merged 1 commit into from
Sep 27, 2021
Merged

get relative path of overlay currently being updated for link #816

merged 1 commit into from
Sep 27, 2021

Conversation

KPostOffice
Copy link
Member

Related Issues and Dependencies

Links in issues on failed update were linking to root Pipfile/Pipfile.lock rather than the overlay which is currently being updated.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 15, 2021
harshad16
harshad16 approved these changes Sep 27, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@harshad16 harshad16 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 27, 2021
@sesheta
Copy link
Member

sesheta commented Sep 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@sesheta
Copy link
Member

sesheta commented Sep 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta merged commit b6c853d into thoth-station:master Sep 27, 2021
@harshad16 harshad16 mentioned this pull request Sep 28, 2021
Closed
@KPostOffice KPostOffice deleted the bf/link_to_overlay_dir branch December 15, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@pacospace pacospace Awaiting requested review from pacospace

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KPostOffice @sesheta @harshad16