Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Kebechet SLI/SLO metrics [update, advise, version] #574

Merged

Conversation

xtuchyna
Copy link
Member

@xtuchyna xtuchyna commented Jun 9, 2022

Related Issues and Dependencies

Closes #572 #598 #599 #600

This introduces a breaking change

  • No

This should yield a new module release

  • Yes

This Pull Request implements

Currently the data is stored as a csv in following format (tested only on 3 repositories thoth-station/mi-scheduler,thoth-station/mi,thoth-station/thoth-github-action, with update manager left out)

Kebechet SLI/SLO metrics

>>> sli_slo_metrics.head() # accessing as pandas dataframe
                        advise  version update  overall_repositories
repository_usage_count       3        3      3                     3

at location ./srcopsmetrics/metrics/kebechet_sli_slo.csv

Kebechet usage indicators

34,thoth-station/thoth-github-action,advise,1655453223
35,thoth-station/thoth-github-action,advise,1655979995
51,thoth-station/thoth-github-action,version,1655194485
40,thoth-station/thoth-github-action,version,1654004461
36,thoth-station/thoth-github-action,version,1653991518
0,thoth-station/mi,advise,1571990467
1,thoth-station/mi,advise,1574353722

at location ./srcopsmetrics/metrics/kebechet_sli_slo.csv

Example file

sli/slo metrics file

kebechet_sli_slo.csv

usage count file

kebechet_usage_counts.csv

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 9, 2022
@xtuchyna xtuchyna changed the title Add basic functions in wip state Kebechet sli slo metrics [WIP] Jun 9, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Jun 9, 2022

/hold

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2022
@sesheta sesheta added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 22, 2022
@sesheta sesheta removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 22, 2022
@xtuchyna
Copy link
Member Author

/cc @goern

@xtuchyna
Copy link
Member Author

xtuchyna commented Jul 20, 2022

Looking at the original issue, it has many goals and extensions, so it is not clear what follows.
What should we prioritize and do next, should we split the Issue or just complete it in this PR (which could be a blocker for basic metrics that are already implemented) ? @goern @Gkrumbach07 @codificat

@xtuchyna
Copy link
Member Author

Added usage indicators

@xtuchyna xtuchyna changed the title Kebechet sli slo metrics [WIP] Kebechet SLI/SLO metrics [WIP] Jul 21, 2022
@xtuchyna
Copy link
Member Author

Closes #598 #599 #600

@xtuchyna
Copy link
Member Author

xtuchyna commented Aug 1, 2022

/unhold

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 1, 2022
@xtuchyna
Copy link
Member Author

xtuchyna commented Aug 1, 2022

/cc @Gkrumbach07 @goern

@xtuchyna xtuchyna changed the title Kebechet SLI/SLO metrics [WIP] Kebechet SLI/SLO metrics [update, advise, version] Aug 1, 2022
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 1, 2022
@goern
Copy link
Member

goern commented Aug 8, 2022

is this ready to merge? I didnt have a look at the code, but would like to see what the metrics report or dashboard looks like.

@Gkrumbach07
Copy link
Member

The usage metrics look good. Did you plan on exporting a aggregate output of each repos usage, or will that be the job of the dashboard? @xtuchyna

@xtuchyna
Copy link
Member Author

@Gkrumbach07 we can definitely add it to the SLI/SLO dataframe or create an aggregate output on its own

@xtuchyna
Copy link
Member Author

@goern all the data file examples this functionality generates are attached to the PR description, and yes I feel like this can be merged

@xtuchyna
Copy link
Member Author

/approve

@sesheta
Copy link
Member

sesheta commented Aug 11, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xtuchyna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2022
@sesheta sesheta merged commit d2fcda4 into thoth-station:master Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Kebechet Managers SLO/SLI metrics
4 participants