Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pre-commit configuration #30

Merged
merged 1 commit into from
May 6, 2022

Conversation

codificat
Copy link
Member

Related Issues and Dependencies

At the moment #29 is failing pre-commit checks

This introduces a breaking change

  • No

This Pull Request implements

Signed-off-by: Pep Turró Mauri <pep@redhat.com>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 6, 2022
@codificat codificat mentioned this pull request May 6, 2022
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks 💯

@sesheta
Copy link
Member

sesheta commented May 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign pacospace after the PR has been reviewed.
You can assign the PR to them by writing /assign @pacospace in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit 4124473 into thoth-station:master May 6, 2022
@codificat codificat deleted the pre-commit-update branch May 9, 2022 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants