Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included all the requirements for the build of images #4

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

harshad16
Copy link
Member

included all the requirements for the build of images
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: #2

Description

Dockerfile has the binary requirement installation for pytesseract and opencv

@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 30, 2021
.s2i/environment Outdated Show resolved Hide resolved
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One last comment is for scikit image, also part of the ds generic image actually, but lets go ahead for now

@pacospace
Copy link
Contributor

/assign @goern

@goern
Copy link
Member

goern commented Jul 1, 2021

/approve

@sesheta
Copy link
Member

sesheta commented Jul 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern, pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2021
@sesheta sesheta merged commit d9d88f4 into thoth-station:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants