Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Substitute contoml with toml #147

Merged
2 commits merged into from
Oct 7, 2019
Merged

Substitute contoml with toml #147

2 commits merged into from
Oct 7, 2019

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Oct 7, 2019 •
edited
Loading

Fixes: #146

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 7, 2019
@ghost
Copy link

ghost commented Oct 7, 2019

Build failed.

@ghost
Copy link

ghost commented Oct 7, 2019

Build succeeded.

fridex
fridex commented Oct 7, 2019
View reviewed changes
Pipfile Show resolved Hide resolved
@fridex fridex requested a review from pacospace October 7, 2019 09:34
@ghost
Copy link

ghost commented Oct 7, 2019

Build failed.

@ghost
Copy link

ghost commented Oct 7, 2019

Build succeeded.

@fridex fridex requested a review from goern October 7, 2019 10:55
pacospace
pacospace approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@pacospace pacospace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2019
@fridex fridex mentioned this pull request Oct 7, 2019
Closed
@ghost
Copy link

ghost commented Oct 7, 2019

Build succeeded (gate pipeline).

@ghost ghost merged commit 4358997 into thoth-station:master Oct 7, 2019
@sesheta sesheta mentioned this pull request Oct 7, 2019
Merged
@fridex fridex deleted the remove-contoml branch October 10, 2019 16:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacospace pacospace pacospace approved these changes

@goern goern Awaiting requested review from goern

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failed to parse Pipfile
3 participants
@fridex @pacospace @sesheta