Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Fix dependencies and use overlays #90

Closed
wants to merge 2 commits into from

Conversation

pacospace
Copy link
Contributor

Signed-off-by: Francesco Murdaca fmurdaca@redhat.com

Related Issues and Dependencies

Fixes: #89
Fixes: #87

This introduces a breaking change

  • Yes
  • No

Description

Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@sesheta
Copy link
Member

sesheta commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pacospace after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested a review from LaVLaS January 31, 2022 13:35
@sesheta sesheta added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 31, 2022
@sesheta
Copy link
Member

sesheta commented Jan 31, 2022

Pre-Commit Test failed! Click here
[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/psf/black.
[ERROR] The hook `black` requires pre-commit version 2.9.2 but version 2.4.0 is installed.  Perhaps run `pip install --upgrade pre-commit`.

Signed-off-by: Francesco Murdaca <fmurdaca@redhat.com>
@sesheta
Copy link
Member

sesheta commented Jan 31, 2022

Pre-Commit Test failed! Click here
[INFO] Initializing environment for https://github.com/Lucas-C/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Initializing environment for https://github.com/psf/black.
[ERROR] The hook `black` requires pre-commit version 2.9.2 but version 2.4.0 is installed.  Perhaps run `pip install --upgrade pre-commit`.

@harshad16
Copy link
Member

@pacospace thanks for the pr
however we are not maintaining this repo anymore
as the s2i-generic-data-science has taken over.
i will put this info on the readme and archive this repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
3 participants