Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch the 403 from the index which are forbidden #5233

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Catch the 403 from the index which are forbidden #5233

merged 2 commits into from
Oct 20, 2022

Conversation

harshad16
Copy link
Member

Catch the 403 from the index which are forbidden
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: #5182

@sesheta sesheta added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2022
mayaCostantini
mayaCostantini approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@mayaCostantini mayaCostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! 💯

@sesheta
Copy link
Member

sesheta commented Oct 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2022
@mayaCostantini
Copy link
Contributor

Failing test is due to missing new version of thoth-python module, let's update the dependencies after this PR merges.

@mayaCostantini
Copy link
Contributor

/retest

@harshad16
Catch the 403 from the index which are forbidden
67acc0e 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
Update the dependency for pytest fix
b5cef28 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@sesheta sesheta added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 20, 2022
@mayaCostantini mayaCostantini merged commit 3ea20ac into thoth-station:master Oct 20, 2022
@harshad16 harshad16 mentioned this pull request Oct 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayaCostantini mayaCostantini mayaCostantini approved these changes

@KPostOffice KPostOffice Awaiting requested review from KPostOffice

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshad16 @sesheta @mayaCostantini