Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using prescriptions from pickle file #1950

Merged
merged 1 commit into from
Sep 15, 2021
Merged

Start using prescriptions from pickle file #1950

merged 1 commit into from
Sep 15, 2021

Conversation

fridex
Copy link
Contributor

@fridex fridex commented Sep 14, 2021

Related Issues and Dependencies

Fixes: thoth-station/prescriptions#50

@fridex fridex marked this pull request as draft September 14, 2021 07:33
@sesheta sesheta added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 14, 2021
@fridex fridex mentioned this pull request Sep 14, 2021
Closed
3 tasks
@fridex fridex marked this pull request as ready for review September 14, 2021 21:24
@sesheta sesheta removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2021
harshad16
harshad16 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks 💯

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@sesheta
Copy link
Member

sesheta commented Sep 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2021
@sesheta
Copy link
Member

sesheta commented Sep 15, 2021

New changes are detected. LGTM label has been removed.

@sesheta sesheta removed the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2021
@sesheta sesheta merged commit e53128f into thoth-station:master Sep 15, 2021
@sesheta sesheta added this to the 2021.09.13 milestone Sep 15, 2021
@fridex fridex deleted the prescriptions-pickle branch September 15, 2021 09:47
@fridex fridex mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshad16 harshad16 harshad16 approved these changes

@pacospace pacospace Awaiting requested review from pacospace

Assignees

@harshad16 harshad16

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
2021.09.13
Development

Successfully merging this pull request may close these issues.

Optimize prescriptions loading
3 participants
@fridex @sesheta @harshad16