Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the sync of the fedora35 python 3.10 solvers #2525

Merged
merged 2 commits into from
May 4, 2022
Merged

Start the sync of the fedora35 python 3.10 solvers #2525

merged 2 commits into from
May 4, 2022

Conversation

harshad16
Copy link
Member

@harshad16 harshad16 commented Apr 25, 2022 •
edited
Loading

Start the sync of the fedora35 python 3.10 solvers
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Fixes: #2479
Related-to: thoth-station/s2i-thoth#231

Description

start the solver execution for the f35-py3.10 based solvers.

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 25, 2022
@harshad16
Copy link
Member Author

/assign @fridex

PTAL, this would start the solver sync.

@goern
Copy link
Member

goern commented Apr 26, 2022

/hold
the container image tag is missing, and the build is blocked by thoth-station/s2i-thoth#242

@sesheta sesheta added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@harshad16
Start the sync of the fedora35 python 3.10 solvers
1d835ab 
Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@harshad16
Copy link
Member Author

the container image tag is missing, and the build is blocked by thoth-station/s2i-thoth#242

good catch , i had tagged a wrong image.
Ready for review again.
/unhold
https://quay.io/repository/thoth-station/solver-fedora-35-py310?tab=tags

@sesheta sesheta removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2022
@harshad16 harshad16 mentioned this pull request Apr 26, 2022
Closed
fridex
fridex reviewed Apr 26, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, otherwise LGTM! 💯

core/overlays/test/configmaps.yaml Outdated Show resolved Hide resolved
@harshad16
Copy link
Member Author

Merging this as already reviewed by reviwers
/approve

@sesheta
Copy link
Member

sesheta commented May 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2022
@sesheta sesheta merged commit 0058c69 into thoth-station:master May 4, 2022
@harshad16 harshad16 deleted the start-f35-py310 branch January 17, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex left review comments

@pacospace pacospace Awaiting requested review from pacospace

Assignees

@fridex fridex

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

start f35-py310 ingestion
4 participants
@harshad16 @goern @sesheta @fridex