Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

😶‍🌫️ Remove unused env var in graph-sync job #2727

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

harshad16
Copy link
Member

Remove unused env var in graph-sync job
Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

Related Issues and Dependencies

Related-to: thoth-station/graph-sync-job#678

Signed-off-by: Harshad Reddy Nalla <hnalla@redhat.com>
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2023
@codificat
Copy link
Member

/test kustomize-build

@codificat
Copy link
Member

Should this also be removed from the job openshift template?

- name: AMUN_API_URL
valueFrom:
configMapKeyRef:
key: amun-api-url
name: thoth

@harshad16
Copy link
Member Author

Should this also be removed from the job openshift template?

- name: AMUN_API_URL
valueFrom:
configMapKeyRef:
key: amun-api-url
name: thoth

yes, as removed in the pr

@codificat
Copy link
Member

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@sesheta
Copy link
Member

sesheta commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codificat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@sesheta sesheta merged commit d753029 into thoth-station:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants