Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET api ​/container-images expecting list of images in container_images , instead it's in parameters dict #1780

Closed
shreekarSS opened this issue Jul 26, 2022 · 5 comments · Fixed by #1802
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@shreekarSS
Copy link
Member

Describe the bug

Expecting list of images in container_images , instead it's in parameters dict
{
"container_images": [],
"parameters": {
"cuda_version": "11.1",
"image_name": null,
"library_name": "/lib64/ld-2.28.so",
"os_name": "ubi",
"os_version": "9",
"package_name": "tensorflow",
"page": 0,
"per_page": 25,
"python_version": "3.9",
"rpm_package_name": "ghc-srpm-macros-1.4.2-7.el8.noarch",
"symbol": "GLIBC_2.2.5"
}
}

To Reproduce
Steps to reproduce the behavior:

  1. Try https://khemenu.thoth-station.ninja/api/v1/ui/#/Container%20Images/list_thoth_container_images

Expected behavior
API should list of images in container_images dict

@shreekarSS shreekarSS added the kind/bug Categorizes issue or PR as related to a bug. label Jul 26, 2022
@shreekarSS shreekarSS self-assigned this Aug 8, 2022
@harshad16
Copy link
Member

Based on the issue it seems like
we are lacking data on the DB for python 3.9 for ubi9

however for the other patterns we do have solutions here:

curl -X 'GET' \
  'https://khemenu.thoth-station.ninja/api/v1/container-images?page=0&per_page=25&os_name=ubi&os_version=8&python_version=3.8' \
  -H 'accept: application/json'

@harshad16
Copy link
Member

The issue here is on empty result, instead of 404 data not found,
api is sending the 200 error code.

@harshad16
Copy link
Member

harshad16 commented Aug 30, 2022

We are missing the 404 error description for this function:

@goern
Copy link
Member

goern commented Sep 5, 2022

what is the status on this?

@shreekarSS
Copy link
Member Author

what is the status on this?

PR is yet get merged

@KPostOffice KPostOffice added triage/accepted Indicates an issue or PR is ready to be actively worked on. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants