Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

​/container-images 404 error code fix #1802

Merged
merged 1 commit into from
Sep 13, 2022
Merged

​/container-images 404 error code fix #1802

merged 1 commit into from
Sep 13, 2022

Conversation

shreekarSS
Copy link
Member

Related Issues and Dependencies

Fixes: #1780
…

This Pull Request implements

Implement #1780 (comment)

@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2022
@sesheta sesheta added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 1, 2022
KPostOffice
KPostOffice reviewed Sep 7, 2022
View reviewed changes
thoth/user_api/api_v1.py Outdated
return (
{
"container_images": entries,
"parameters": parameters,
},
200,
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still needed here as navigation info. Return type should be a Union

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it

harshad16
harshad16 requested changes Sep 7, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that the header dict is removed ,
it should be present , in 404 contion pass empty dict

thoth/user_api/api_v1.py Outdated Show resolved Hide resolved
@shreekarSS
Add 404 error description for /container-images endpoint
1577263 
Add check for empty list of entries to throw 404 error code

Signed-off-by: Shreekara <sshreeka@redhat.com>
@KPostOffice
Copy link
Member

/lgtm

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2022
harshad16
harshad16 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks 💯

@KPostOffice
Copy link
Member

/approve

mayaCostantini
mayaCostantini approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@mayaCostantini mayaCostantini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 💯

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 12, 2022
@harshad16
Copy link
Member

/test aicoe-ci/prow/pre-commit

@sesheta
Copy link
Member

sesheta commented Sep 12, 2022

@harshad16: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pre-commit

Use /test all to run all jobs.

In response to this:

/test aicoe-ci/prow/pre-commit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harshad16
Copy link
Member

/test pre-commit

2 similar comments
@KPostOffice
Copy link
Member

/test pre-commit

@shreekarSS
Copy link
Member Author

/test pre-commit

harshad16
harshad16 approved these changes Sep 13, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
thanks

@sesheta
Copy link
Member

sesheta commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16, KPostOffice, mayaCostantini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KPostOffice,harshad16,mayaCostantini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit ab32cad into thoth-station:master Sep 13, 2022
@harshad16 harshad16 mentioned this pull request Sep 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KPostOffice KPostOffice KPostOffice left review comments

@harshad16 harshad16 harshad16 approved these changes

@mayaCostantini mayaCostantini mayaCostantini approved these changes

Assignees

@harshad16 harshad16

@KPostOffice KPostOffice

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GET api ​/container-images expecting list of images in container_images , instead it's in parameters dict
5 participants
@shreekarSS @KPostOffice @harshad16 @sesheta @mayaCostantini