This repository has been archived by the owner on Nov 18, 2017. It is now read-only.
Validate against empty comments #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @jferris |
| sendResponseStatus status201 $ object | ||
| ["comment" .= UserComment (Entity cid c) u] | ||
|
|
||
| updateComment :: CommentId -> Entity User -> CommentRequest -> Handler Value |
There was a problem hiding this comment.
insertComment and updateComment are pretty similar. I'm guessing it would get kludgy if you tried to abstract over them, but it's something that jumped out at me.
There was a problem hiding this comment.
That was what I found, the placement and relative ratio of the differences (time given to toComment, action given to runDB, and status given to sendResponseStatus) is such that, even though the functions have the same shape, any DRYing just decreases readability (IMO).
- Assert that an empty POST triggers a 400 validation error - assertEqual should be expected, then actual
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{"errors":["Useful error","..."]}in invalid casesI'm not sure yet if or how the client-side handles these errors.