fix #867 by adding keyword argument params #917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which Rails version are you getting this on? |
|
Oh, gotcha, this is Rails 5, thanks. |
mygulamali
added a commit
that referenced
this pull request
Sep 23, 2016
Rails 5 has deprecated the keywords arguments for #permit. This patch scopes the request params according to the version of Rails. Fixes #867. Supercedes #917 with passing tests. Thank you to @freesteph for helpin' out!
mygulamali
added a commit
that referenced
this pull request
Sep 23, 2016
Rails 5 has deprecated the keywords arguments for #permit. This patch scopes the request params according to the ActionPack version. Fixes #867. Supercedes #917 with passing tests. Thank you to @freesteph for helpin' out!
|
This was fixed by ce9624b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops triggering the deprecation warning: ActionController::TestCase HTTP request methods will accept only keyword arguments in future Rails versions.