Skip to content
This repository was archived by the owner on May 3, 2023. It is now read-only.

Conversation

GiacomoSorbi
Copy link
Contributor

This PR includes changes for resolving high severity issues and most of low level ones.

image

@GiacomoSorbi GiacomoSorbi added the dependencies Pull requests that update a dependency file label Jan 26, 2021
@GiacomoSorbi GiacomoSorbi self-assigned this Jan 26, 2021
@PeterJCLaw
Copy link

I realise this repo doesn't have a PR template to prompt for this, but it would be good to record how this was tested?

@GiacomoSorbi GiacomoSorbi requested a review from lirsacc January 26, 2021 14:41
@PeterJCLaw PeterJCLaw removed their request for review January 26, 2021 19:16
Copy link

@lirsacc lirsacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks alright. Although I am not sure I have enough context to properly assess all the changes.

+1 on @PeterJCLaw's comment, how was this tested? If we're confident the everything still works then it should be all right.

I reckon this may require a release of the package, WDYT? Unfortunately I don't know the process for this.

@GiacomoSorbi GiacomoSorbi merged commit 46b1dab into master Jan 27, 2021
@jackfranklin
Copy link
Contributor

@lirsacc hey! 👋 Saw this pop up in my GitHub emails. Let me know if you need any help with the release process...everything should be in place but I'm happy to help if anything isn't.

@GiacomoSorbi
Copy link
Contributor Author

@jackfranklin Saw your kind reply here, yup I highly recommend you to create a new release with updated deps.

@tavva
Copy link

tavva commented Feb 2, 2021

@GiacomoSorbi This is our repo - Jack no longer works at Thread, he's offered to help if we need it though. Thanks Jack, we'll take it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

5 participants