Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene.d.ts: Background does not support WebGLCubeRenderTarget anymore. #33

Merged
merged 4 commits into from
Feb 26, 2021
Merged

Scene.d.ts: Background does not support WebGLCubeRenderTarget anymore. #33

merged 4 commits into from
Feb 26, 2021

Conversation

Mugen87
Copy link
Contributor

@Mugen87 Mugen87 commented Feb 26, 2021 •
edited
Loading

Why

With r127, Scene.background does not support WebGLCubeRenderTarget anymore, see mrdoob/three.js#21360.

What

Remove WebGLCubeRenderTarget from Scene.d.ts.

Checklist

  • Added myself to contributors table
  • Ready to be merged

@joshuaellis joshuaellis changed the base branch from master to dev February 26, 2021 10:29
@joshuaellis joshuaellis added this to the r127 milestone Feb 26, 2021
@joshuaellis joshuaellis mentioned this pull request Feb 26, 2021
Closed
18 tasks
joshuaellis
joshuaellis approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@Mugen87
Copy link
Contributor Author

Mugen87 commented Feb 26, 2021

For a separate PR: It seems WebGLRenderTarget is imported in Scene.d.ts although it is never used...

@joshuaellis joshuaellis merged commit f291572 into three-types:dev Feb 26, 2021
@Mugen87 Mugen87 deleted the patch-1 branch February 26, 2021 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r127
Development

Successfully merging this pull request may close these issues.
2 participants
@Mugen87 @joshuaellis