-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Atari SAC examples #657
Conversation
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
=======================================
Coverage 93.62% 93.63%
=======================================
Files 71 71
Lines 4755 4757 +2
=======================================
+ Hits 4452 4454 +2
Misses 303 303
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
It is a serious bug so I stole it to #659. |
ping me if it's ready |
It's ready. I tried some parameter-tuning but couldn't improve the Breakout result. The original paper also reported very low score for Breakout game. I see no point going further. Please review. @Trinkle23897 |
- Add Atari (discrete) SAC examples; - Fix a bug in Discrete SAC evaluation; default to deterministic mode.
make format
(required)make commit-checks
(required)