Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Atari SAC examples #657

Merged
merged 5 commits into from
Jun 4, 2022
Merged

add Atari SAC examples #657

merged 5 commits into from
Jun 4, 2022

Conversation

nuance1979
Copy link
Collaborator

@nuance1979 nuance1979 commented Jun 1, 2022

  • I have marked all applicable categories:
    • exception-raising fix
    • algorithm implementation fix
    • documentation modification
    • new feature
  • I have reformatted the code using make format (required)
  • I have checked the code using make commit-checks (required)
  • If applicable, I have mentioned the relevant/related issue(s)
  • If applicable, I have listed every items in this Pull Request below
  • Add Atari (discrete) SAC examples;
  • Fix a bug in Discrete SAC evaluation; default to deterministic mode.

@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #657 (de7dfa9) into master (5ecea24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #657   +/-   ##
=======================================
  Coverage   93.62%   93.63%           
=======================================
  Files          71       71           
  Lines        4755     4757    +2     
=======================================
+ Hits         4452     4454    +2     
  Misses        303      303           
Flag Coverage Δ
unittests 93.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tianshou/policy/modelfree/discrete_sac.py 86.56% <100.00%> (+0.41%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@Trinkle23897
Copy link
Collaborator

Fix an off-by-one bug in trainer iterator;

It is a serious bug so I stole it to #659.

@Trinkle23897
Copy link
Collaborator

ping me if it's ready

@nuance1979
Copy link
Collaborator Author

ping me if it's ready

It's ready.

I tried some parameter-tuning but couldn't improve the Breakout result. The original paper also reported very low score for Breakout game. I see no point going further. Please review. @Trinkle23897

@Trinkle23897 Trinkle23897 merged commit 9ce0a55 into thu-ml:master Jun 4, 2022
@nuance1979 nuance1979 deleted the atari_sac branch June 7, 2022 18:39
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
- Add Atari (discrete) SAC examples;
- Fix a bug in Discrete SAC evaluation; default to deterministic mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants