Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix save_checkpoint_fn return value #659

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

Trinkle23897
Copy link
Collaborator

@Trinkle23897 Trinkle23897 commented Jun 2, 2022

Close #658

  • Fix save_checkpoint_fn return value to checkpoint_path;
  • Fix wrong link in doc;
  • Fix an off-by-one bug in trainer iterator.

@Trinkle23897 Trinkle23897 mentioned this pull request Jun 2, 2022
9 tasks
@Trinkle23897 Trinkle23897 merged commit 5ecea24 into thu-ml:master Jun 2, 2022
@Trinkle23897 Trinkle23897 deleted the save-ckpt-fn-return branch June 2, 2022 17:07
BFAnas pushed a commit to BFAnas/tianshou that referenced this pull request May 5, 2024
- Fix save_checkpoint_fn return value to checkpoint_path;
- Fix wrong link in doc;
- Fix an off-by-one bug in trainer iterator.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save_checkpoint_fn is expected to have no return value but WandbLogger use it as checkpoint_path
1 participant