Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for accessibility profiles #785

Merged
merged 6 commits into from
Oct 13, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Sep 29, 2023

Pull Request Description

This PR adds support for accessibility profiles. An accessibility profile is a list of settings and suggested values. Applying the profile will toggle the settings to the suggested values. Note that applying a profile doesn't lock you in to those settings; you may still manually set anything. Also the profile can be applied any time or any number of times. It is essentially just a "baseline".

In the UI, each profile displays a description (why one might want to use this profile) as well as a list of the settings and values.

Once the framework is in place, it will be very easy to add new profiles (you essentially just create a widget, and pass the list of settings and desired values), and we can solicit these from the community. To start, this PR intoduces one initial profile for Screen Readers with the settings suggested in #778.

Technical note: Currently only boolean-based settings are supported as part of a profile, but I don't think it would be hard to add others. Just something to keep in mind.

@shortwavesurfer2009 Can you take a look and let us know if this is what you had in mind based on our discussion?

Issue Being Fixed

Issue Number: #778

Screenshots / Recordings

qemu-system-x86_64_Rs4211haPy.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@shortwavesurfer2009
Copy link

Looks good from what i can see

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just some discussion points that I wanted to bring up!

lib/settings/widgets/accessibility_profile.dart Outdated Show resolved Hide resolved
lib/settings/widgets/accessibility_profile.dart Outdated Show resolved Hide resolved
@hjiangsu hjiangsu merged commit f0b2cfb into thunder-app:develop Oct 13, 2023
1 check passed
@micahmo micahmo deleted the feature/accessibility-profiles branch October 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants