Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show already posted to #879

Merged
merged 5 commits into from
Nov 7, 2023

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Nov 6, 2023

Pull Request Description

This PR expands on the recent cross-posts addition to show the communities where a given URL has already been posted while you're creating a new post. This solves a particular use case I've been running into where I've wondered "has this article been shared yet?". Now I can send it to Thunder, see if it's been shared in the community I wanted to post to. If so, I can just jump there and read the comments. If not, I can post it myself!

P.S. As part of these changes I refactored the CrossPosts widget out of the PostView. I also made some other changes to support inclusion in the create post page. So if you want to see the diff I suppose you can copy the deleted and added versions and compare! Or just look for the usage of the newPost property.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_rJDAM1I37g.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments! Let me know your thoughts

lib/shared/cross_posts.dart Outdated Show resolved Hide resolved
lib/community/pages/create_post_page.dart Outdated Show resolved Hide resolved
lib/community/pages/create_post_page.dart Outdated Show resolved Hide resolved
@micahmo
Copy link
Member Author

micahmo commented Nov 7, 2023

Should be all set now!

@hjiangsu hjiangsu merged commit 1fbc5ef into thunder-app:develop Nov 7, 2023
1 check passed
@micahmo micahmo deleted the feature/already-posted-to branch November 7, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants