Skip to content

Refactor many pages to support proper suspensions #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 11, 2025
Merged

Refactor many pages to support proper suspensions #1524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4ae86a0
Refactor many pages to support proper suspensions
Oksamies Sep 6, 2025
cb87bf3
Add image lazy loading and improve env variable logic
Oksamies Sep 8, 2025
6200c56
Uh, more skeletons? And some improvements to perceived performance
Oksamies Sep 10, 2025
4cf6b95
Update styles and mobile responsivity
Oksamies Sep 11, 2025
9b344ac
Merge pull request #1528 from thunderstore-io/09-11-update_styles_and…
Oksamies Sep 11, 2025
9e29e19
Merge pull request #1527 from thunderstore-io/09-10-uh_more_skeletons…
Oksamies Sep 11, 2025
92caf50
Merge pull request #1526 from thunderstore-io/09-09-add_image_lazy_lo…
Oksamies Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 157 additions & 16 deletions apps/cyberstorm-remix/app/c/Community.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,34 +8,148 @@
gap: 1rem;
align-items: flex-start;
align-self: stretch;
padding: 7.5rem 3rem 2rem;
padding: 1rem 3rem 2rem;
}

.community__header {
display: flex;
flex-direction: column;
align-items: flex-start;
align-self: stretch;

/* min-height: 6.25rem; */
}

.community__background {
position: absolute;
display: flex;
flex-direction: column;
align-items: center;
align-self: stretch;
justify-content: center;
max-height: 12.5rem;
border-radius: 0.5rem;
overflow-y: hidden;
transition: height 2s;

> img {
border-radius: 0.5rem;
background: var(--color-ui-surface-1);
opacity: 0.8;
}

.skeleton {
height: 12.5rem;
}
}

.community__background--packagePage {
height: 6.25rem;

> img {
opacity: 0.3;
mix-blend-mode: luminosity;
}
}

.community__content-header-wrapper {
z-index: 1;
display: flex;
flex-wrap: wrap;
gap: 1.5rem;
place-items: flex-end stretch;
align-self: stretch;
justify-content: space-between;
height: max-content;
margin-top: -1rem;
padding-left: 1rem;
transition:
height ease 1s,
opacity 0.2s,
visibility 1s 0s;
}

.community__content-header {
display: flex;
flex-grow: 1;
gap: 1.5rem;
align-items: flex-end;
align-self: stretch;
min-width: 75%;
height: max-content;
}

.community__content-header--hide {
height: 0;
visibility: collapse;
opacity: 0;
transition:
height ease 1s,
opacity 0.8s 0.2s,
visibility 1s 0s;
}
Comment on lines +81 to +89
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

visibility: collapse isn’t widely supported outside table/grid. Use hidden and disable interaction.

This makes the hide state reliable across browsers.

-    visibility: collapse;
+    visibility: hidden;
+    pointer-events: none;
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.community__content-header--hide {
height: 0;
visibility: collapse;
opacity: 0;
transition:
height ease 1s,
opacity 0.8s 0.2s,
visibility 1s 0s;
}
.community__content-header--hide {
height: 0;
visibility: hidden;
pointer-events: none;
opacity: 0;
transition:
height ease 1s,
opacity 0.8s 0.2s,
visibility 1s 0s;
}
🤖 Prompt for AI Agents 
In apps/cyberstorm-remix/app/c/Community.css around lines 81 to 89, the
.community__content-header--hide rule uses visibility: collapse which isn’t
reliably supported outside table/grid contexts; change it to visibility: hidden
and also disable interaction by adding pointer-events: none (optionally keep
overflow: hidden for safety) so the hidden state works consistently across
browsers while preserving the existing height/opacity/transition behavior.


.community__game-icon {
display: flex;
gap: 0.5rem;
align-items: center;
width: 7rem;
height: 7rem;
padding: var(--Space-12, 0.75rem);
border: 1px solid var(--Color-border-bright, rgb(70 70 149 / 0.66));
border-radius: var(--Radius-xl, 1rem);
background: var(--Color-Surface-1, #070721);
aspect-ratio: 1/1;
}

.community__game-icon-tinified {
display: flex;
flex: 1 0 0;
align-items: center;
justify-content: center;
height: 5.5rem;

> img {
width: 5.5rem;
height: 5.5rem;
}
}

.community__content-header-content {
display: flex;
flex-direction: column;
flex-grow: 1;
gap: 0.75rem;
align-items: flex-start;
height: 20rem;
border-radius: var(--section-border-radius);
overflow: hidden;
justify-content: center;
}

.community__background-image {
.community__header-info {
display: flex;
flex: 1 0 0;
flex-direction: column;
gap: 0.25rem;
align-items: flex-start;
background: var(--color-body-bg-color, #101028);
align-self: stretch;
min-width: 60%;
max-width: 100%;

opacity: 0.4;
mix-blend-mode: luminosity;
> h1 {
line-height: 80%;
overflow-wrap: anywhere;
}
}

.community__background-tint {
position: absolute;
width: 100%;
height: 20rem;
background: linear-gradient(180deg, rgb(16 16 40 / 0.4) 0%, #101028 85.94%);
.community__header-meta {
display: flex;
flex: 0 1 60%;
gap: 1.5rem;
align-items: center;
min-width: 60%;
height: 16px;

> .skeleton {
height: 1rem;
}
}

.community__small-image {
Expand All @@ -62,7 +176,7 @@
.community__meta {
display: flex;
flex-wrap: wrap;
gap: var(--gap-xxxl);
gap: var(--gap-3xl);
align-items: center;
}

Expand All @@ -80,9 +194,36 @@
}
}

@media (width >= 41rem) {
.community__background {
height: 12.5rem;
}
}

@media (width < 41rem) {
.community__background {
.skeleton {
height: 8rem;
}
}

.community__header {
gap: 1rem;
}

.community__content-header-wrapper {
margin-top: 0;
padding-left: 0;
}

.community__game-icon {
display: none;
}
}

@media (width <= 48rem) {
.community__meta {
gap: var(--gap-xxs);
gap: var(--gap-2xs);
}

.community__item {
Expand Down
Loading
Loading