-
Notifications
You must be signed in to change notification settings - Fork 5
Fix type imports in Nimbus #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2b91be9
to
f3a2fdd
Compare
29e6e51
to
c09d0a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes type imports across the Cyberstorm Remix application by adding explicit type
qualifiers to import statements. This improves build performance and follows TypeScript best practices by clearly distinguishing between type-only and runtime imports.
- Added explicit
type
qualifiers to type-only imports throughout the codebase - Reorganized some import statements for better structure
- Removed unused imports in a few files
Reviewed Changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
apps/cyberstorm-remix/cyberstorm/utils/LinkLibrary.tsx | Added type qualifiers to interface imports and reorganized import structure |
apps/cyberstorm-remix/app/upload/upload.tsx | Added type qualifiers to various API and React type imports |
apps/cyberstorm-remix/app/tools/markdown-preview/markdownPreview.tsx | Added type qualifier to RequestConfig import |
apps/cyberstorm-remix/app/tools/manifest-validator/manifestValidator.tsx | Added type qualifier to RequestConfig import |
apps/cyberstorm-remix/app/settings/user/Connections/Connections.tsx | Added type qualifier to ReactElement import |
apps/cyberstorm-remix/app/settings/teams/team/teamSettings.tsx | Removed unused imports (NewBreadCrumbs, NewBreadCrumbsLink) |
apps/cyberstorm-remix/app/settings/teams/team/tabs/Settings/Settings.tsx | Added type qualifiers to API type imports |
apps/cyberstorm-remix/app/settings/teams/team/tabs/ServiceAccounts/ServiceAccounts.tsx | Added type qualifiers to React Router and API type imports |
apps/cyberstorm-remix/app/settings/teams/team/tabs/Profile/Profile.tsx | Added type qualifiers to React Router and API type imports |
apps/cyberstorm-remix/app/settings/teams/team/tabs/Members/Members.tsx | Added type qualifiers to various imports including React Router and component types |
apps/cyberstorm-remix/app/settings/teams/Teams.tsx | Added type qualifiers to API and root type imports |
apps/cyberstorm-remix/app/p/tabs/Wiki/*.tsx | Added type qualifiers to LoaderFunctionArgs and API type imports across wiki components |
apps/cyberstorm-remix/app/p/tabs/Versions/Versions.tsx | Added type qualifiers to table and component type imports |
apps/cyberstorm-remix/app/p/tabs/Required/Required.tsx | Added type qualifier to LoaderFunctionArgs import |
apps/cyberstorm-remix/app/p/tabs/Readme/Readme.tsx | Added type qualifier to LoaderFunctionArgs import |
apps/cyberstorm-remix/app/p/tabs/Changelog/Changelog.tsx | Added type qualifier to LoaderFunctionArgs import |
apps/cyberstorm-remix/app/p/packageListing.tsx | Added type qualifiers to API and component types, removed unused imports |
apps/cyberstorm-remix/app/p/packageEdit.tsx | Added type qualifier to API type import |
apps/cyberstorm-remix/app/p/components/TeamMembers/TeamMembers.tsx | Added type qualifiers to Dapper type imports |
apps/cyberstorm-remix/app/healthz.tsx | Added type qualifier to LoaderFunctionArgs import |
apps/cyberstorm-remix/app/communities/communities.tsx | Added type qualifier to Communities import, removed commented import |
apps/cyberstorm-remix/app/commonComponents/*.tsx | Added type qualifiers to various React and component type imports across common components |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c09d0a0
to
0d2b8af
Compare
f3a2fdd
to
15c1c7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
No description provided.