Skip to content

Feature: Tibia Houses endpoints #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jan 13, 2022
Merged

Feature: Tibia Houses endpoints #26

merged 22 commits into from
Jan 13, 2022

Conversation

tobiasehlert
Copy link
Member

@tobiasehlert tobiasehlert commented Jan 5, 2022 •
edited
Loading

This feature includes following endpoints:

  • GET /v3/houses/world/:world/house/:houseid
  • GET /v3/houses/world/:world/town/:town

@tobiasehlert tobiasehlert added documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code labels Jan 5, 2022
@tobiasehlert tobiasehlert force-pushed the feature-houses branch 4 times, most recently from 0131de2 to db914e7 Compare January 9, 2022 02:13
@tibiadata tibiadata deleted a comment from sonarqubecloud bot Jan 9, 2022
@codecov
Copy link

codecov bot commented Jan 11, 2022 •
edited
Loading

Codecov Report

Merging #26 (5f8470f) into main (635641c) will increase coverage by 26.41%.
The diff coverage is 0.00%.

❗ Current head 5f8470f differs from pull request most recent head 3819e3b. Consider uploading reports for the commit 3819e3b to get more accurate results

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
+ Coverage   21.54%   47.95%   +26.41%     
===========================================
  Files          17       21        +4     
  Lines        2715     3184      +469     
===========================================
+ Hits          585     1527      +942     
+ Misses       2109     1600      -509     
- Partials       21       57       +36

This was referenced Jan 13, 2022
Closed
Merged
@tobiasehlert
adding ignore for mapping json
653bf50 
because it's supposed to be included in build process
@tobiasehlert
adding HouseMapping file
bba4722 
adding run in TibiaDataInitializer
@tobiasehlert
adding houseid resolver in houseshouse file
c98ccc1
@tobiasehlert
moving init before start of webserver
c7109ab
@tobiasehlert
adding more logging to mapping init func
180836e 
so the log tells if it sails collecting mappings
@tobiasehlert
adding omitempty to town and type
5f8470f 
so if mapping fails, they are now displayed
@tobiasehlert
switching from local file to dwnload from
3819e3b 
github in startup
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tobiasehlert tobiasehlert self-assigned this Jan 13, 2022
@tobiasehlert tobiasehlert marked this pull request as ready for review January 13, 2022 23:20
@tobiasehlert tobiasehlert merged commit 2f820d3 into main Jan 13, 2022
@tobiasehlert tobiasehlert deleted the feature-houses branch January 13, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tobiasehlert tobiasehlert

Labels
documentation Improvements or additions to documentation enhancement New feature or request go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasehlert @phenpessoa