Skip to content

Removing duplicate function #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 5, 2022
Merged

Removing duplicate function #27

merged 2 commits into from
Jan 5, 2022

Conversation

tobiasehlert
Copy link
Member

Today there are multiple ways of running html.UnescapeString.
This PR is replacing html.UnescapeString and TibiadataUnescapeStringV3 with TibiaDataSanitizeEscapedString.

@tobiasehlert
multiple ways of unescaping strings..
2cb13d0 
from: html.UnescapeString and TibiadataUnescapeStringV3
to: TibiaDataSanitizeEscapedString
@tobiasehlert
removing TibiadataUnescapeStringV3 func
1e8f7ca
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Jan 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tobiasehlert tobiasehlert merged commit 0987cd2 into main Jan 5, 2022
@tobiasehlert tobiasehlert deleted the removing-duplicate-function branch January 5, 2022 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tobiasehlert