Skip to content

use new assert instead of passing t many times #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2022
Merged

use new assert instead of passing t many times #45

merged 1 commit into from
Jan 9, 2022

Conversation

phenpessoa
Copy link
Contributor

As per https://github.com/stretchr/testify we should use assert.New(t) instead of passing t many times.
This PR aims to do that.

tobiasehlert
tobiasehlert approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@tobiasehlert tobiasehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tobiasehlert tobiasehlert merged commit afdf2d5 into tibiadata:main Jan 9, 2022
@phenpessoa phenpessoa deleted the assert branch February 16, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasehlert tobiasehlert tobiasehlert approved these changes

+1 more reviewer

@kamilon kamilon kamilon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phenpessoa @tobiasehlert @kamilon