Skip to content

Handle timezone information during DateTime parsing #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 9, 2022
Merged

Handle timezone information during DateTime parsing #46

merged 5 commits into from
Jan 9, 2022

Conversation

kamilon
Copy link
Contributor

@kamilon kamilon commented Jan 9, 2022 •
edited
Loading

Fixes #42

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #46 (f065fd5) into main (afdf2d5) will increase coverage by 0.00%.
The diff coverage is 81.81%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #46   +/-   ##
=======================================
  Coverage   13.25%   13.25%           
=======================================
  Files          13       14    +1     
  Lines        1803     1795    -8     
=======================================
- Hits          239      238    -1     
+ Misses       1556     1549    -7     
  Partials        8        8
Impacted Files Coverage Δ
src/webserver.go 10.08% <ø> (-3.03%) ⬇️
src/TibiaDataUtils.go 81.81% <81.81%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afdf2d5...f065fd5. Read the comment docs.

@tobiasehlert tobiasehlert changed the base branch from main to bug-42 January 9, 2022 21:45
@tobiasehlert tobiasehlert merged commit 3fbda66 into tibiadata:bug-42 Jan 9, 2022
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Jan 9, 2022
tobiasehlert added a commit that referenced this pull request Jan 10, 2022
@tobiasehlert @kamilon
Handle timezone information during DateTime parsing (#46) (#49)
b080c52 
* Handle timezone information during DateTime parsing (#46)

* adjusting asserts to be UTC

* updating TibiadataDatetimeV3 with correct format

* adding loading of Europe/Berlin timezone and changing time parsing to include that location

* cleaning

Co-authored-by: kamilon <kennedybushnell@kamilon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix TibiadataDatetimeV3 UTC timezone problem
3 participants
@kamilon @codecov-commenter @tobiasehlert