Skip to content

Conversation

tobiasehlert
Copy link
Member

Cleaning up in characters deaths:

  • removing TruncatedDeaths
  • switching from object to array of object

- switching from object to array of object
@tobiasehlert tobiasehlert added the go Pull requests that update Go code label Jan 28, 2022
@tobiasehlert tobiasehlert self-assigned this Jan 28, 2022
@tobiasehlert
Copy link
Member Author

Before change:

	"deaths": {
		"death_entries": [{
			"assists": [{
				"name": "string",
				"player": false,
				"summon": "string",
				"traded": false
			}],
			"killers": [{
				"name": "string",
				"player": false,
				"summon": "string",
				"traded": false
			}],
			"level": 0,
			"reason": "string",
			"time": "string"
		}],
		"truncated": false
	}

After change:

	"deaths": [{
		"assists": [{
			"name": "string",
			"player": false,
			"summon": "string",
			"traded": false
		}],
		"killers": [{
			"name": "string",
			"player": false,
			"summon": "string",
			"traded": false
		}],
		"level": 0,
		"reason": "string",
		"time": "string"
	}]

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 28, 2022

Codecov Report

Merging #75 (314ac5d) into main (902821d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   76.65%   76.64%   -0.01%     
==========================================
  Files          21       21              
  Lines        2609     2608       -1     
==========================================
- Hits         2000     1999       -1     
  Misses        533      533              
  Partials       76       76              

@tobiasehlert tobiasehlert merged commit c3d5b0f into main Jan 31, 2022
@tobiasehlert tobiasehlert deleted the adjusting-chars-deathlist branch January 31, 2022 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Development

Successfully merging this pull request may close these issues.

2 participants