Skip to content

improve look and feel of documentation #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dcolebatch
Copy link
Member

Using CoPilot Agent mode, and various models as well as some elbow grease, this PR updates the plumbing and styling:

  • Updated github pages stack
  • Updated Dockerfile
  • Tweaks to styling (fonts, spacing, some colour)
  • Darkmode :godmode:
image

Copy link

netlify bot commented May 6, 2025

Deploy Preview for tidal-guides ready!

Name Link
🔨 Latest commit 0e3103f
🔍 Latest deploy log https://app.netlify.com/sites/tidal-guides/deploys/681cd23af7bf9600084e35d4
😎 Deploy Preview https://deploy-preview-285--tidal-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dcolebatch
Copy link
Member Author

Hmm - right, netlify.
Does anyone have any tips on updating netlify to use latest ruby?

image

I doubt this is needed - AI hallucination?
@dcolebatch
Copy link
Member Author

The david-assisted GitHub CoPilot Agent Mode trial is over. The results are: https://681cd23af7bf9600084e35d4--tidal-guides.netlify.app/#

My takeaway is:

  • Powerful for improving productivity
  • Helps you to learn new things
  • Reduces cognitive load
  • but try to improve your build toolchain first :)

@@ -1,4 +1,4 @@
FROM ruby:2.1
FROM ruby:3.3.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this Docker image is used. Do you know?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used for local dev/build environments is all I could determine. The AI even used it to serve it up to me.

@dcolebatch dcolebatch merged commit b7ffdd3 into tidalmigrations:master May 8, 2025
4 checks passed
@SamDesmondKing
Copy link
Contributor

FYI page sub-headers are now invisible in light mode
image

@SamDesmondKing
Copy link
Contributor

Also, in my opinion it would be better if the color palette in both light and dark mode adhered to our style guide's established color palette.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this empty file here?

@SamDesmondKing
Copy link
Contributor

I was going to open a PR to address my concerns here but I see Justin has started a full re-write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants