-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android): Added Ti.App "close" event support #10637
Conversation
- Removed KrollRuntime state RELAUNCHED. No longer relevant. - Removed KrollRuntime CountDownLatch. No longer needed since Kroll thread is not supported.
FR passed. Event fired when back button clicked and kitchen sink works fine with live view. build failed in jenkin. Waiting for CR . Operating System |
|
@garymathews, I'm going to push this PR out from 8.1.0 to 8.3.0 since it makes high risk changes to our kroll runtime. |
FR passed, but still needs a CR cc @garymathews @ypbnv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
JIRA:
https://jira.appcelerator.org/browse/TIMOB-26542
Summary:
V8Object
andV8Function
to allow V8 calls while in the "released" state.RELAUNCH
state. No longer needed since 8.0.0's intent refactoring and now that Services/BroadcastReceivers won't keep JS runtime alive anymore.CountDownLatch
. No longer needed since JS runtime can only be ran from UI thread.V8Object
andV8Function
to allow V8 calls whileKrollRuntime
is in theRELEASED
state, which happens when anOnDisposingListener
is being invoked.cancelTimers()
call fromKrollRuntime
toTiApplication
.Note:
I've noticed that our
TiApplication.softRestart()
does not follow the rules and calls theV8Runtime
's dispose/init methods directly. This means ourOnDisposingListener
s won't get invoked. TheTi.App._restart()
handling still works with my PR (I've tested it), but we may want to look into this in the future.Close Event Test:
### App 'close' event was fired.
LiveView Test:
This test verifies that our runtime restart changes work okay.