fix(android): fix build deps #13317
Merged
fix(android): fix build deps #13317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1ga
reviewed
Mar 19, 2022
| @@ -174,7 +174,7 @@ async function createSnapshot() { | |||
| // Post rolled-up "ti.main" script to server and obtain a snapshot ID as a response. | |||
| // We will send an HTTP request for the snapshot code later. | |||
| console.log('Attempting to request snapshot...'); | |||
| const snapshotUrl = 'https://v8-snapshot.appcelerator.com'; | |||
| const snapshotUrl = 'http://v8-snapshot.appcelerator.com'; // TODO: Migrate to Github Artifacts once ready | |||
There was a problem hiding this comment.
Tested it on a Mac and I had the same certificate error. This change fixed it 👍
|
Don't have the Kotlin problem with my Macbook Air (Intel, 2020), macOS 12.2.1, Android Studio 2021.1.1 Patch 2, Java 15.0.1). I can build an SDK with just the URL fix but having a newer Kotlin version doesn't hurt. The SDK doesn't use any Kotlin files so I'm not sure why it would fail 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local build was failing because of two reasons: