-
Notifications
You must be signed in to change notification settings - Fork 93
Closed
Labels
upkeepmaintenance, infrastructure, and similarmaintenance, infrastructure, and similar
Description
We add eval_time
to all prediction calls in predict_survival.model_fit()
and predict_hazard.model_fit()
which causes problems if the the engine's predict method does not have an eval_time
argument and does not swallow it via the dots, e.g. by enforcing empty dots.
The "aorsf"
engine for rand_forest()
in censored enforces empty dots which is what lead to tidymodels/censored#236. The dev version of censored does not rely on this pattern anymore so once that is on CRAN we should remove those lines:
Lines 37 to 38 in 8f13c1c
# Pass some extra arguments to be used in post-processor | |
object$spec$method$pred$survival$args$eval_time <- eval_time |
Lines 35 to 36 in 8f13c1c
# Pass some extra arguments to be used in post-processor | |
object$spec$method$pred$hazard$args$eval_time <- eval_time |
Metadata
Metadata
Assignees
Labels
upkeepmaintenance, infrastructure, and similarmaintenance, infrastructure, and similar