Skip to content

Remove forced injection of eval_time in predict_survival() #1039

Description

@hfrick

We add eval_time to all prediction calls in predict_survival.model_fit() and predict_hazard.model_fit() which causes problems if the the engine's predict method does not have an eval_time argument and does not swallow it via the dots, e.g. by enforcing empty dots.

The "aorsf" engine for rand_forest() in censored enforces empty dots which is what lead to tidymodels/censored#236. The dev version of censored does not rely on this pattern anymore so once that is on CRAN we should remove those lines:

# Pass some extra arguments to be used in post-processor
object$spec$method$pred$survival$args$eval_time <- eval_time

# Pass some extra arguments to be used in post-processor
object$spec$method$pred$hazard$args$eval_time <- eval_time

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    upkeepmaintenance, infrastructure, and similar

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions