Skip to content

LiblineaR penalty does *not* allow submodel "trick" #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 14, 2021
Merged

LiblineaR penalty does *not* allow submodel "trick" #552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6c4188
Change LiblineaR penalty to submodel = FALSE
juliasilge Sep 13, 2021
dec1246
Update NEWS
juliasilge Sep 13, 2021
739234d
Actually update NEWS
juliasilge Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

* A bug for class predictions of two-class GAM models was fixed (#541)

* Fixed a bug for `logistic_reg()` with the LiblineaR engine (#552).


# parsnip 0.1.7

Expand Down
2 changes: 1 addition & 1 deletion R/logistic_reg_data.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ set_model_arg(
parsnip = "penalty",
original = "cost",
func = list(pkg = "dials", fun = "penalty"),
has_submodel = TRUE
has_submodel = FALSE
)

set_model_arg(
Expand Down