Validation time split NOT working

[pgg1309]

Hi,
The validation_time_split() is not working as expected when lag is used.

The calculation seems to be correct but in the end the source code removes the out_id using the function rm_out(split). As a result one gets always the same results for assessment regardless of the lag used.

It seems to be a simple fix, but I do not know how to make a pull request. Would appreciate if you could fix that. Thanks.

[hfrick]

thanks for the report @pgg1309 !

library(rsample)
library(dplyr)

toy_data <- data.frame(id = 1:100)
(val_rset <- validation_time_split(toy_data, prob = 75, lag = 2))
#> # Validation Set Split (0.75/0.25)  
#> # A tibble: 1 × 2
#>   splits          id        
#>   <list>          <chr>     
#> 1 <split [75/25]> validation

# internally, this splits it into
# analysis: 1:n_train -> here 1:75
# assessment:  (n_train + 1 - lag):nrow(data) -> here 74:100

# but that's not what remains:
analysis(val_rset$splits[[1]]) %>% pull(id)
#>  [1]  1  2  3  4  5  6  7  8  9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
#> [26] 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50
#> [51] 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75
assessment(val_rset$splits[[1]]) %>% pull(id)
#>  [1]  76  77  78  79  80  81  82  83  84  85  86  87  88  89  90  91  92  93  94
#> [20]  95  96  97  98  99 100

^{Created on 2022-11-22 with reprex v2.0.2}

[github-actions]

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.