-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with Modeltime #2
Comments
Sounds great! Thanks for all the detail. The features you're relying on feel like they should be pretty stable right now, but I'll make sure to let you know if any change. |
The only thing I need is to get the |
Yeah, that's up for the next week or two! I'll drop a note here when we get the basics working. |
Ok, that would be great. I'll then work on |
Once we get the naming conventions down in #13, I’m going to begin working on the Modeltime integration. One concern I have is the butcher (#10). I have a |
Fair warning that development will probably slow up quite a bit for the next month or so, and then pick back up after then. I don't imagine we'd undergo any changes re: #13 beyond finding and replacing function names, so the API should otherwise remain stable in that sense. :-) Still need to spend more time on the butcher methods before I'll have a good sense of what operations will still be able to carried out. Thinking about what a refit would look like, though, if that method uses a new training set, you'd probably need to start back up at the tuning candidates step, since the data stack is made up of the collated assessment set predictions from the tune results. |
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Hey @simonpcouch & @topepo
I'd like to open this issue to keep track of how I plan to use
stacks
within themodeltime
forecasting framework. There shouldn't be anything additional required on your part to get the integration to happen. On my end, I'll just allow amodel_stack
that has been "fitted" (contains a "member_fits" list element) to be allowed in themodeltime_table()
.Once
stacks
is released, just be aware that if you change the argument name or object class names, that it will breakmodeltime
until I can catch up.Plan
The goal is to integrate
model_stack
objects into themodeltime
forecasting workflow similar to how I integrateworkflow
objects.It's quite simple - add the fitted
model_stack
to a Modeltime Table just like you add a fittedworkflow
.Then the fitted model stack will follow the same forecasting workflow.
To achieve this result, there are only a few requirements (things you need to be aware of that are intricacies of time series cross-validation and the
modeltime
forecasting workflow).Modeltime Forecasting Workflow Requirements:
predict()
method and they work just like callingpredict(workflow, new_data)
. Therefore, there should be a way to easily determine if a stack has been fitted or not. Only if a stack has been fitted, can it be added to a Modeltime Table. It looks like this can be detective if a model has a "member_fits" element.rsample
andtimetk
.rsample::rolling_origin()
ortimetk::time_series_cv()
as the grid tuning strategyrsample::initial_time_split()
ortimetk::time_series_split()
as the final training and evaluation sets.The text was updated successfully, but these errors were encountered: