Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intersect_all() and setdiff_all() #414

Closed
adithya604 opened this issue Apr 10, 2020 · 2 comments
Closed

intersect_all() and setdiff_all() #414

adithya604 opened this issue Apr 10, 2020 · 2 comments
Labels
feature a feature request or enhancement verb trans 🤖 Translation of dplyr verbs to SQL
Milestone

Comments

@adithya604
Copy link

adithya604 commented Apr 10, 2020

Teradata supports other set operations like EXCEPT ALL and INTERSECT ALL on the lines of UNION ALL (implemented through union_all.tbl_lazy). Can we have implementations for verbs like intersect_all.tbl_lazy and setdiff_all.tbl_lazy to handle these cases?

@adithya604 adithya604 changed the title Request for intersect_all and setdiff_all Feature Request: intersect_all and setdiff_all Apr 10, 2020
@hadley hadley changed the title Feature Request: intersect_all and setdiff_all intersect_all() and setdiff_all() Apr 14, 2020
@hadley hadley added feature a feature request or enhancement verb trans 🤖 Translation of dplyr verbs to SQL labels Apr 14, 2020
@adithya604
Copy link
Author

@hadley Thanks for making note of the request.
Is it part of the dbplyr pipeline upcoming release and when it will be (estimated)?
Thanks.

@hadley
Copy link
Member

hadley commented Sep 23, 2020

I just marked it as an issue as part of regular issue triage; it wasn't an indication that I planned to work on it. And indeed, when I look at it now, I remember that dplyr::intersect_all() doesn't exist, so implementing a method won't work. It looks like ALL is a valid clause when applied to any of union, intersect, or except so I think we could just add an all argument.

hadley added a commit that referenced this issue Sep 24, 2020
@hadley hadley added this to the 2.0.0 milestone Sep 24, 2020
@hadley hadley closed this as completed in d96dee3 Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement verb trans 🤖 Translation of dplyr verbs to SQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants