Escape raw vectors and support list of raw vectors #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
reviewed
May 14, 2020
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
hadley
reviewed
May 15, 2020
added 2 commits
May 18, 2020 18:16
Merge branch 'master' of https://github.com/okhoma/dbplyr # Conflicts: # R/escape.R
hadley
approved these changes
May 18, 2020
There was a problem hiding this comment.
Looks good! Can you please add a bullet to the top of NEWS.md? It should briefly describe the change and end with (@yourname, #issuenumber).
krlmlr
reviewed
May 19, 2020
|
I also sent a pull request to remove the extraneous magrittr import: https://github.com/okhoma/dbplyr/pull/1/files. |
magrittr reexport now in master
… contains more than one raw vector.
Co-authored-by: Kirill Müller <krlmlr@users.noreply.github.com>
krlmlr
approved these changes
May 19, 2020
|
Thanks! |
okhoma
pushed a commit
to okhoma/dbplyr
that referenced
this pull request
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Please, consider my pull request to support escape of raw vectors and lists of raw vectors.
The motivation is to be able to pass UTF-8 strings into dplyr
filtermethod using a workaround described in r-dbi/DBI#215 (comment). Here, UTF-8 character vectors are converted to list of UTF-16 raw vectors and then the data is properly written into the database. However, when I attempt to filter the table passing raw vectors or list of raw vectors in the same manner, I am getting an errorError in UseMethod("escape") : no applicable method for 'escape' applied to an object of class "raw".