Fixes MS SQL issue of select after arrange #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See discussion in issue as to why this doesn't work 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tidyverse/dplyr#3062
It adds another layer to
sql-optimisethat checks to see if the current query is a SELECT or a FILTER and if the previous query is an ORDER BY and merges the two. The exception is that if in the previous query history is a GROUP BY. The exception is because implementing this optimization for grouped data seems to require a more complex solution that seems to be out of scope of the reported issue.Here are the tests I ran:
test_optimise.pdf