You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
build_query() calls sql_select() to pull together the SQL statement that is passed to a Query constructor. The sql_select() method is generic and can have connection specific methods. However, build_query() is not. Would it make sense to make this an exported generic function so that downstream dependencies are less problematic?
The text was updated successfully, but these errors were encountered:
I see you have deprecated build_query from master vs. v0.4.3 as well as making quite a few other changes. I will wait to see what you end up and if necessary, update request.
lockbot
locked as resolved and limited conversation to collaborators
Jun 9, 2018
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
build_query()
callssql_select()
to pull together the SQL statement that is passed to aQuery
constructor. Thesql_select()
method is generic and can have connection specific methods. However,build_query()
is not. Would it make sense to make this an exported generic function so that downstream dependencies are less problematic?The text was updated successfully, but these errors were encountered: