Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make build_query a generic and implement methods #1114

Closed
imanuelcostigan opened this issue Apr 29, 2015 · 2 comments
Closed

Make build_query a generic and implement methods #1114

imanuelcostigan opened this issue Apr 29, 2015 · 2 comments
Labels
feature a feature request or enhancement
Milestone

Comments

@imanuelcostigan
Copy link
Contributor

build_query() calls sql_select() to pull together the SQL statement that is passed to a Query constructor. The sql_select() method is generic and can have connection specific methods. However, build_query() is not. Would it make sense to make this an exported generic function so that downstream dependencies are less problematic?

@hadley hadley added this to the 0.5 milestone May 19, 2015
@hadley hadley added feature a feature request or enhancement SQL labels Oct 22, 2015
@hadley
Copy link
Member

hadley commented Mar 8, 2016

The point of this method is to do all the complicated NSE stuff so that database backends don't have to. What would you need from the generic?

@hadley hadley closed this as completed Mar 9, 2016
@imanuelcostigan
Copy link
Contributor Author

I see you have deprecated build_query from master vs. v0.4.3 as well as making quite a few other changes. I will wait to see what you end up and if necessary, update request.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants