Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source_df should inherit from data.frame #12

Closed
hadley opened this issue May 16, 2013 · 3 comments
Closed

source_df should inherit from data.frame #12

hadley opened this issue May 16, 2013 · 3 comments

Comments

@hadley
Copy link
Member

hadley commented May 16, 2013

So you can use it as, without having to manually coerce to a data frame. And possibly should do the same thing for data.table

@dmenne
Copy link

dmenne commented May 16, 2013

Yep, and I know of a good test case, lme/nlme (and friends). That's the one which fails (or failed? did not check today) with the implicit casting in data.table.

@hadley
Copy link
Member Author

hadley commented May 16, 2013

But in general, you can't assume that a data source is a data frame, and it will be safer to force the user to acknowledge this by using as.data.frame(). I think one of the things that makes data.table hard to use is that it tries to hard to behave like data frame, even though it works in a profoundly different way.

@dmenne
Copy link

dmenne commented May 16, 2013

Point taken, I had this trouble a few times already. A good error message would be nice, because I remember using quite some time to locate the problem I thought was in lme.

@hadley hadley closed this as completed in b06a2cc May 24, 2013
krlmlr referenced this issue in krlmlr/dplyr Mar 2, 2016
krlmlr referenced this issue in krlmlr/dplyr Mar 2, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants