Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source_sqlite should cache rows #26

Closed
hadley opened this issue Jun 24, 2013 · 1 comment
Closed

source_sqlite should cache rows #26

hadley opened this issue Jun 24, 2013 · 1 comment

Comments

@hadley
Copy link
Member

hadley commented Jun 24, 2013

When loading data - same reasoning as for google bigquery.
@hadley
Copy link
Member Author

hadley commented Aug 12, 2013

This is a bit complicated, because the cache needs to be updated (or at least dirtied) whenever you change the filter, since you might do this several times before printing, and it seems silly to cache every intermediate count. Since the datasource is not mutable, that suggests memoising would be the way forward. But maybe this is just a fundamental limitation of sqlite and shouldn't be hidden from the user?

@hadley hadley closed this as completed Aug 12, 2013
@acthomasca acthomasca mentioned this issue Jun 13, 2015
Closed
krlmlr referenced this issue in krlmlr/dplyr Mar 2, 2016
Merge branch 'feature/26-remove-src-tbl'. Fixes #26.
7548971 
- Functions related to `tbl` and `src` stay in `dplyr` (#26).
krlmlr referenced this issue in krlmlr/dplyr Mar 2, 2016
Merge tag 'v0.1-5'
b454b47 
- Functions related to `tbl` and `src` stay in `dplyr` (#26).
- `data_frame(NULL)` raises error "must be a 1d atomic vector or list".
@lock lock bot locked as resolved and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hadley