Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

group_id pronoun #3341

Closed
krlmlr opened this issue Feb 5, 2018 · 7 comments
Closed

group_id pronoun #3341

krlmlr opened this issue Feb 5, 2018 · 7 comments
Labels
feature a feature request or enhancement wip work in progress

Comments

@krlmlr
Copy link
Member

krlmlr commented Feb 5, 2018

From #1185 (comment).

Not sure if this should be a function (like row_number()) or a pronoun (like .data).

@krlmlr krlmlr added feature a feature request or enhancement data frame labels Feb 5, 2018
@dfrail24
Copy link

dfrail24 commented Feb 9, 2018

Since group_indices is already used to generate a unique id for each group, why can't it just be modified so we can use it inside a mutate function?
At least for others who commented in #1185 and myself, I think it makes more sense to do mutate(g = group_indices()) and append it to the original data frame than it just returning a vector of integers.

@romainfrancois
Copy link
Member

#1185 is ✅ with #3490 which is ready to be merged.

@krlmlr
Copy link
Member Author

krlmlr commented Apr 16, 2018

Reopening, will be auto-closed.

@krlmlr krlmlr reopened this Apr 16, 2018
@romainfrancois
Copy link
Member

there's no close command for this particular issue in #3490

@krlmlr
Copy link
Member Author

krlmlr commented Apr 16, 2018

Thanks, added.

@dfrail24
Copy link

@romainfrancois Hey, thanks for putting your time into this - really appreciate what you've done.
I'll be one of the first to use it once it's merged :)

@krlmlr krlmlr added the wip work in progress label Apr 18, 2018
@lock
Copy link

lock bot commented Nov 1, 2018

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Nov 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature a feature request or enhancement wip work in progress
Projects
None yet
Development

No branches or pull requests

3 participants