Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix group_by() for column names in UTF-8 on Windows #2382

Merged
merged 8 commits into from Jan 27, 2017

Conversation

@krlmlr
Copy link
Member

@krlmlr krlmlr commented Jan 26, 2017

Fixes #2284. Similar to #2058 but at a lower level.

Fixes #2005 and #2277.

@krlmlr
Copy link
Member Author

@krlmlr krlmlr commented Jan 27, 2017

@hadley: PTAL. I'm working on a fix for #1950 based on these changes.

@hadley
Copy link
Member

@hadley hadley commented Jan 27, 2017

LGTM

@krlmlr krlmlr merged commit 0035e99 into tidyverse:master Jan 27, 2017
4 checks passed
@krlmlr krlmlr deleted the b-#2284-select-utf8 branch Jan 27, 2017
@lock
Copy link

@lock lock bot commented Jan 18, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants