Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rchk related fixes #4273

Merged
merged 39 commits into from
Mar 15, 2019
Merged

rchk related fixes #4273

merged 39 commits into from
Mar 15, 2019

Conversation

romainfrancois
Copy link
Member 

while (rhub::check(platform = "ubuntu-rchk") == 🙅‍♀️){
  🕵️‍♂️
}

@romainfrancois romainfrancois added the wip work in progress label Mar 12, 2019
@romainfrancois
check_slice_result() no longer allocate, but protect anyway. rchk.
78d911a
@romainfrancois
protect result of quo.env(). rchk
1fb8af7
@romainfrancois
PROTECT quosure.expr(), as validate_unquoted_value() might alllocate
a22c766
@romainfrancois
some more rchk protection
1875a35
@romainfrancois
simplify get_date_classes() and get_time_classes()
65fe998
@romainfrancois
need (SEXP)
7bf1b93
@romainfrancois
some more rchk
745b04e
@romainfrancois
protect results of vec_names_or_empty()
ddcf42c
@romainfrancois
SymbolVector::init() protects its argument. rchk
03c428b
@romainfrancois
more protection in DataMask::setup()
4b24701
@romainfrancois
more rchk
d5a662e
@romainfrancois
using setAttrib() / getAttrib() instead of Rcpp's attr() to skip 💵 fo…
67e3f3b 
…r Rf_install()
@romainfrancois
more rchk
0f1f911
@romainfrancois
more rchk.
bbc3870
@romainfrancois
more rchk
b2ea124
@romainfrancois
more rchk
78c39c3
@romainfrancois
simplify make_lambda_quosure
51a8192
@romainfrancois
get_uniques() is never used
03a6e38
@romainfrancois
protect column_names. rchk
3ed47ee
@romainfrancois
skip copies
4879db8
@romainfrancois
protect result of wrap before the List ctor.
a2a1941
@romainfrancois
using r_match() instead of SymbolVector.match_in_table()
de2cfbb
@romainfrancois
protect Rf_getAttrib(x, symbols::names)
18a015c
@romainfrancois
more rchk
93c4948
@romainfrancois
using Rcpp::export(rng = false).
b04c22a 
closes #4278
@romainfrancois
rchk says the dtor of N_Distinct might allocate
9c60bff
@romainfrancois
scope the shared_ptr<> for rchk
d12cac3
@romainfrancois
protect from ~Gatherer() dtor. rchk
e7a8b23
@romainfrancois
Cannot dirtectly send the result of match_in_table() in IntegerVector…
0998180 
… because of the unsafe ctor. rchk
@romainfrancois
Copy link
Member Author

The only remaining problems are Rcpp issues for which I've sent pull requests:
RcppCore/Rcpp#947 and RcppCore/Rcpp#949

squashing this as it's a lot of 🥓 making.

@romainfrancois romainfrancois merged commit af75177 into master Mar 15, 2019
@romainfrancois romainfrancois deleted the rchk_fixes branch March 15, 2019 13:40
@lock
Copy link

lock bot commented Sep 11, 2019

This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/

@lock lock bot locked and limited conversation to collaborators Sep 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
wip work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@romainfrancois