Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeProxy::set() #947

Merged
merged 7 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@romainfrancois
Copy link
Contributor

romainfrancois commented Mar 12, 2019

closes #946

@kevinushey

This comment has been minimized.

Copy link
Contributor

kevinushey commented Mar 13, 2019

LGTM!

} else {
/* use the slower and more flexible version (callback to R) */
SEXP namesSym = Rf_install( "names<-" );
Shield<SEXP> new_vec(Rcpp_fast_eval(Rf_lang3(namesSym, parent, x), R_GlobalEnv));
Shield<SEXP> call(Rf_lang3(namesSym, parent, x));

This comment has been minimized.

Copy link
@romainfrancois

romainfrancois Mar 13, 2019

Author Contributor

Was unsafe to not protect the result of Rf_lang3

/* check if we can use a fast version */
if( TYPEOF(x) == STRSXP && parent.size() == Rf_length(x) ){
SEXP y = parent.get__() ;
Rf_setAttrib( y, R_NamesSymbol, x ) ;
Rf_namesgets(parent, x);

This comment has been minimized.

Copy link
@romainfrancois

romainfrancois Mar 13, 2019

Author Contributor

That's what Rf_namesgets is for.

@romainfrancois romainfrancois force-pushed the romainfrancois:rchk branch from 1999b5c to 76b92d2 Mar 13, 2019

romainfrancois added a commit to tidyverse/dplyr that referenced this pull request Mar 14, 2019

romainfrancois added a commit to tidyverse/dplyr that referenced this pull request Mar 14, 2019

romainfrancois added a commit to tidyverse/dplyr that referenced this pull request Mar 15, 2019

@romainfrancois romainfrancois referenced this pull request Mar 15, 2019

Merged

rchk related fixes #4273

romainfrancois added a commit to tidyverse/dplyr that referenced this pull request Mar 15, 2019

rchk related fixes (#4273)
* check_slice_result() no longer allocate, but protect anyway. rchk.

* protect result of quo.env(). rchk

* PROTECT quosure.expr(), as validate_unquoted_value() might alllocate

* some more rchk protection

* simplify get_date_classes() and get_time_classes()

* need (SEXP)

* some more rchk

* protect results of vec_names_or_empty()

* SymbolVector::init() protects its argument. rchk

* more protection in DataMask::setup()

* more rchk

* using setAttrib() / getAttrib() instead of Rcpp's attr() to skip 💵 for Rf_install()

* more rchk

* more rchk.

* more rchk

* more rchk

* simplify make_lambda_quosure

* get_uniques() is never used

* protect column_names. rchk

* skip copies

* protect result of wrap before the List ctor.

* using r_match() instead of SymbolVector.match_in_table()

* protect Rf_getAttrib(x, symbols::names)

* more rchk

* using Rcpp::export(rng = false).

closes #4278

* rchk says the dtor of N_Distinct might allocate

* scope the shared_ptr<> for rchk

* protect from ~Gatherer() dtor. rchk

* Cannot dirtectly send the result of match_in_table() in IntegerVector because of the unsafe ctor. rchk

* trying RcppCore/Rcpp#949 to see if it helps quiet some rchk 😱

* - Remote

* rm unused nprot

* Shield<> before CharacterVector ctor, until RcppCore/Rcpp#947 gets merged in Rcpp.

* Revert "- Remote"

This reverts commit 72bb9aa.

* SymbolMap(DataFrame) ctor to avoid rchk issue with the SymbolMap(CharacterVector) ctor

* Forbid copy construction of GroupedDataFrame and SymbolMap

* limit copies of SymbolVector

* 🏃 a branch that incorporates changes from both Rcpp PRs:

RcppCore/Rcpp#947
RcppCore/Rcpp#949

* use CRAN Rcpp

@eddelbuettel eddelbuettel merged commit 7203f32 into RcppCore:master Mar 16, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

eddelbuettel added a commit that referenced this pull request Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.