Rlang call update #240
Merged
Rlang call update #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hadley
reviewed
Jan 31, 2020
.Rbuildignore
Outdated
| @@ -16,3 +16,6 @@ | |||
| ^revdep$ | |||
| ^\.github$ | |||
| ^LICENSE\.md$ | |||
| ^forcats\.Rcheck$ | |||
There was a problem hiding this comment.
It's not a big deal to add these, but it suggests something might be wonky with your process, as they should end up in the parent directory, not here.
There was a problem hiding this comment.
Ok! I'm running it from RStudio Cloud. Thank you for the tip!
NEWS.md
Outdated
| @@ -6,6 +6,8 @@ | |||
|
|
|||
| * fixed bug in `fct_collapse()` so it now correctly collapses factors when `group_other = TRUE` (#172), and makes `"Other"` the last level (#202) (@gtm19, #172 & #202) | |||
|
|
|||
| * Updated calls to **rlang** package (#233). Package called globally with `@import rlang` instead of `rlang::` calls. Removed all `rlang::` calls (@gralgomez, @gabrielodom, #233) | |||
There was a problem hiding this comment.
For future reference, you don't need a news bullet here since it doesn't affect the user of the package.
There was a problem hiding this comment.
Gotcha! Thanks
|
Thank you @gralgomez and @gabrielodom! |
|
I think you can move your issue directly to gonged 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked on issue #233 with @gabrielodom