Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremental_*() functions #63

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

incremental_*() functions #63

wants to merge 5 commits into from

Conversation

romainfrancois
Copy link
Member

initially copies of the functions from dplyr, except using vec_assert(logical()).

are we expecting to use C, C++ in funs ?

@romainfrancois
Copy link
Member Author

closes #39

@romainfrancois
Copy link
Member Author

"cumulative any" and "cumulative all" don't really feel right, given how these are documented in dplyr, perhaps we can find other ways to express them:

#' @section Cumulative logical functions:
#'
#' These are particularly useful in conjunction with `filter()`:
#'
#' * `cumall(x)`: all cases until the first `FALSE`.
#' * `cumall(!x)`: all cases until the first `TRUE`.
#' * `cumany(x)`: all cases after the first `TRUE`.
#' * `cumany(!x)`: all cases after the first `FALSE`.

@romainfrancois
Copy link
Member Author

How about incremental_*() for the whole cum_* family from #5 ?

@romainfrancois romainfrancois changed the title cumany(), cumall() incremental functions May 5, 2021
@romainfrancois romainfrancois changed the title incremental functions incremental_*() functions May 5, 2021
@romainfrancois romainfrancois marked this pull request as ready for review May 17, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant