check.class argument to ggsave #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
optional by-pass of ggsave checks that an object of class ggplot is being recorded. In addition, a grid.draw method is defined, rather than calling print() directly, to allow other grobs such as modified gtables to be saved.
|
Hmmm, I don't really like adding an additional argument. Any thoughts on alternative ways to check if it's saveable? Maybe we could have? is_gridable <- function(x) UseMethod("is_gridable")
is_gridable.ggplot <- function(x) TRUE
is_gridable.grob <- function(x) TRUE
is_gridable.default <- function(x) FALSE? |
|
Done in 7387d39 |
|
Thanks! Any particular reason to have grid.draw.ggplot() calling print.ggplot(), and not the opposite? |
|
You're the one who wrote that ;) it probably should be the other way around but it required a bit too much thinking |
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional by-pass of ggsave checks that an object of class ggplot is being recorded.
In addition, a grid.draw method is defined, rather than calling print()
directly, to allow other grobs such as modified gtables to be saved to a device with the same convenience.